Adding Location Cache #2801
Adding Location Cache #2801
Conversation
read me change
ItemOptions-changes 41f2acf if_match_etag changes with tests * main b1d2f9f [origin/main] Merge pull request #1 from gsa9989/read-me-change read-me-change 653b308 read me change Please enter a commit message to explain why this merge is necessary, ItemOption-changes 41f2acf if_match_etag changes with tests * main b1d2f9f [origin/main] Merge pull request #1 from gsa9989/read-me-change read-me-change 653b308 merge upstream/main
…ter a commit message to explain why this merge is necessary,
gsa9989
changed the title
gsa9989
requested review from
analogrelay,
Pilchie,
kirankumarkolli,
tvaron3,
FabianMeiswinkel,
kundadebdatta,
nehrao1 and
kushagraThapar
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds location cache functionality to the Azure Cosmos SDK, providing a system to organize database account data and manage endpoint availability. The location cache tracks client preferred locations, available read/write regions, and endpoint availability to provide optimal endpoint selection for database operations.
Key Changes:
- Added comprehensive location cache implementation with endpoint management and availability tracking
- Implemented API methods for updating, refreshing, and resolving service endpoints
- Added extensive test coverage for all location cache functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| sdk/cosmos/azure_data_cosmos/src/location_cache.rs | Complete implementation of LocationCache with availability tracking, endpoint management, and comprehensive test suite |
| sdk/cosmos/azure_data_cosmos/src/lib.rs | Added module declarations for location_cache and global_endpoint_manager |
| sdk/cosmos/azure_data_cosmos/src/global_endpoint_manager.rs | Added empty GlobalEndpointManager struct placeholder |
Updates done via pair programming (I couldn't merge directly 😭 )
… gaby/global-endpoint-manager
…re/azure-sdk-for-rust into gaby/global-endpoint-manage
There was a problem hiding this comment.
LGTM, thanks @gsa9989
Though I am curious, do we need to add the license header on top of the location_cache.rs file?
|
Ah, we do! Good catch @kushagraThapar . I'm bad at remembering that and we don't have any automation in place yet :(. @gsa9989 you can just grab the two comment lines from the top of any other Rust source file and add it in. |
PR Summary:
Implementation details:
Current limitations: